Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33820 )
Change subject: mb/google/hatch: Set trackpad irq and wake to GPP_A21
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/33820/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33820/2//COMMIT_MSG@17
PS2, Line 17: powerd_dbus_suspend
What about wake from S3? Does that work too?
https://review.coreboot.org/#/c/33820/2/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/33820/2/src/mainboard/google/hatch/variants/...
PS2, Line 208: D22
D21?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33820
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26a99206c42ba442f91ae577b98366fc2fd6c0ca
Gerrit-Change-Number: 33820
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Philip Chen
philipchen@google.com
Gerrit-Comment-Date: Thu, 27 Jun 2019 02:25:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment