Attention is currently required from: Felix Held, Maximilian Brune.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86386?usp=email )
Change subject: device/pci_rom: Support non VGA iGPUs
......................................................................
Patch Set 4:
(1 comment)
File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/86386/comment/f79d6ec6_74ae5d6e?usp... :
PS4, Line 210: ((uintptr_t)rom < MiB) ? "initialized " : "", rom);
does the location and the initialization status correlate? i don't think so. […]
The original code assumed that VGA_ROM_RUN was being used and the ROM in the C-segment had been run. Thus the check. Since it's also being used by FSP this message hasn't been updated and isn't necessarily true any more.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86386?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I623cd80b45b148b91f2796b22a589bbede0feeeb
Gerrit-Change-Number: 86386
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 25 Feb 2025 12:09:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de