Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41894 )
Change subject: vendorcode/google/chromeos: Add vendor_dptf_* functions ......................................................................
Patch Set 7:
(3 comments)
I wonder if this shouldn't come from ec/google/chromeec rather than chromeos. in theory you could still use the chrome ec with DPTF but without CONFIG_CHROMEOS.
I guess that makes it hard for ec/google/wilco to use it, so maybe it needs something new in ec/google/dptf...
https://review.coreboot.org/c/coreboot/+/41894/7/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/dptf.c:
https://review.coreboot.org/c/coreboot/+/41894/7/src/vendorcode/google/chrom... PS7, Line 194: acpigen_write_if(); : acpigen_emit_byte(LEQUAL_OP); : acpigen_emit_byte(LOCAL0_OP); : acpigen_write_integer(i); /* TMPI */ is this acpigen_write_if_lequal_op_int()?
https://review.coreboot.org/c/coreboot/+/41894/7/src/vendorcode/google/chrom... PS7, Line 198: acpigen_emit_byte(NOTIFY_OP); : acpigen_emit_namestring(name); : acpigen_write_integer(THERMAL_EVENT); this seems like a good candidate for a new function like acpigen_notify(namestr, val) since it gets used a couple times.
https://review.coreboot.org/c/coreboot/+/41894/7/src/vendorcode/google/chrom... PS7, Line 276: "TMPI" could this just use tsr_index to build a name instead of relying on TMPI to be defined?