Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/19621 )
Change subject: mb/google/poppy:[WIP] Add MIPI camera support.
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/19621/1/src/mainboard/google/poppy/acpi/came...
File src/mainboard/google/poppy/acpi/camera.asl:
PS1, Line 221: PCTL
This is a bug.
VALU should be written to the CFG1 register.
PS1, Line 358: PCTL
This is a bug.
VALU should be written to the CFG1 register.
--
To view, visit
https://review.coreboot.org/19621
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If32a2a8313488d2f50aad3feaa79e17b1d06c80f
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hyungwoo Yang
hyungwoo.yang@intel.com
Gerrit-Reviewer: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes