Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40724 )
Change subject: drivers/intel/gma: Move IGD OpRegion to CBMEM
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40724/5/src/soc/intel/tigerlake/gra...
File src/soc/intel/tigerlake/graphics.c:
https://review.coreboot.org/c/coreboot/+/40724/5/src/soc/intel/tigerlake/gra...
PS5, Line 39: reg32
Command register is 16bit
Yes, I know. That's why I fixed it in a later commit (which triggered a
lot of other patches). :)
This patch however, doesn't even touch the line. I merely copied a comment
from above it below.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fdd6634e4a671a85b1df8bc9815296ff42edf29
Gerrit-Change-Number: 40724
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 May 2020 14:35:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment