12 Apr
2023
12 Apr
'23
2:37 p.m.
Attention is currently required from: Nico Huber.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74331 )
Change subject: device: Change NO_S0IX_SUPPORT default to def_bool ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Sorry, this breaks my understanding of Kconfig. Can you elaborate what doesn't […]
starlabs/starbook has `select NO_S0IX_SUPPORT`.
With `def_bool` it's actually selected, with `default` it doesn't.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74331
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc824c3e06019c8922616c1cb83df95c10e285fc
Gerrit-Change-Number: 74331
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Wed, 12 Apr 2023 12:37:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment