Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32549 )
Change subject: soc/intel/common: Hook up GMA ACPI brightness controls ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/32549/6/src/soc/intel/common/block/... File src/soc/intel/common/block/graphics/graphics.c:
https://review.coreboot.org/c/coreboot/+/32549/6/src/soc/intel/common/block/... PS6, Line 36: struct Nit, could be const.
https://review.coreboot.org/c/coreboot/+/32549/6/src/soc/intel/common/block/... PS6, Line 41: unused Why not pass it along? it looks really odd, especially because we need to look it up inside intel_igd_get_controller_info() otherwise, and check for presence, enabled... If this function (or any of the `device_operations`) gets called, the passed `struct device *` is non-NULL and the device is enabled.
https://review.coreboot.org/c/coreboot/+/32549/6/src/soc/intel/common/block/... PS6, Line 43: struct Here too, in case.