Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35225 )
Change subject: soc/intel/common/block/cse: Move me_read_config32() to common code ......................................................................
Patch Set 20:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35225/17/src/soc/intel/apollolake/c... File src/soc/intel/apollolake/cse.c:
https://review.coreboot.org/c/coreboot/+/35225/17/src/soc/intel/apollolake/c... PS17, Line 189:
same as CNL
Done
https://review.coreboot.org/c/coreboot/+/35225/17/src/soc/intel/cannonlake/m... File src/soc/intel/cannonlake/me.c:
https://review.coreboot.org/c/coreboot/+/35225/17/src/soc/intel/cannonlake/m... PS17, Line 188:
if (!is_heci_enable()) […]
Done
https://review.coreboot.org/c/coreboot/+/35225/17/src/soc/intel/cannonlake/m... PS17, Line 189: if (!me_read_config32(PCI_ME_HFSTS1, &hfsts1.raw)) : return;
don't need any change here […]
Done
https://review.coreboot.org/c/coreboot/+/35225/17/src/soc/intel/cannonlake/m... PS17, Line 249:
same as above. […]
Done
https://review.coreboot.org/c/coreboot/+/35225/17/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35225/17/src/soc/intel/common/block... PS17, Line 505:
add helper function to check HECI is enable/visible before asking for read status […]
Done
https://review.coreboot.org/c/coreboot/+/35225/17/src/soc/intel/common/block... PS17, Line 506: int
uint32_t me_read_config32(int offset) […]
Done
https://review.coreboot.org/c/coreboot/+/35225/17/src/soc/intel/skylake/me.c File src/soc/intel/skylake/me.c:
https://review.coreboot.org/c/coreboot/+/35225/17/src/soc/intel/skylake/me.c... PS17, Line 241: if (!me_read_config32(PCI_ME_HFSTS1, &hfs.data))
same as CNL
Done
https://review.coreboot.org/c/coreboot/+/35225/18/src/soc/intel/skylake/me.c File src/soc/intel/skylake/me.c:
https://review.coreboot.org/c/coreboot/+/35225/18/src/soc/intel/skylake/me.c... PS18, Line 245:
remove this extra line ?
Done
https://review.coreboot.org/c/coreboot/+/35225/18/src/soc/intel/skylake/me.c... PS18, Line 491: return status;
goto ret; just to make consistency if you wish ?
Done
https://review.coreboot.org/c/coreboot/+/35225/18/src/soc/intel/skylake/me.c... PS18, Line 495:
same here ?
Done