Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31493 )
Change subject: cbfstool: Add ifittool
......................................................................
Patch Set 10:
(6 comments)
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c
File util/cbfstool/fit.c:
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@249
PS9, Line 249: int
this could just return void since the return code has no meaning
Done
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@299
PS9, Line 299: mcu_header->total_size
I know this is left over from the original, but if this were left out and it just used "? :" then th […]
Done
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@353
PS9, Line 353: The
There
Done
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@354
PS9, Line 354: Type 2 entry
I know it is defined in the header, but it would be useful to use FIT_TYPE_BIOS_ACM (etc) in these c […]
Done
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@399
PS9, Line 399: entry->size_reserved = lcp_policy_size;
This is overwriting the setting from the previous line, except it is not converting to multiple of 1 […]
Done
https://review.coreboot.org/#/c/31493/9/util/cbfstool/fit.c@446
PS9, Line 446: struct microcode_entry *mcu
This threw me for a minute trying to find where it was declared, style guide suggests this should be […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31493
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fe8cd70611d58823aca1147d5b830722ed72bd5
Gerrit-Change-Number: 31493
Gerrit-PatchSet: 10
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Amol N Sukerkar
amol.n.sukerkar@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jens Drenhaus
jens.drenhaus@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kai Michaelis
kai.michaelis@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Roy Wen
rgzwen@arista.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Tue, 30 Apr 2019 09:05:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment