James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31382 )
Change subject: ec/quanta/it8518: Use ACPI EC code
......................................................................
Patch Set 1:
Patch Set 1:
any specific tests you'd like me to do on Stout? I cherry picked this and everything EC-related (battery, kb, mouse) seemed to work ok under both Windows and Linux
Are you able to specifically test that the "input buffer full" and "output buffer empty" situations behave as expected? I'm not sure how to do this.
I'm reasonably confident it should do the same thing (the timeout is slightly different), but it would be good to specifically test it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31382
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bea7445f34817cef1602843bbded59230bb8d47
Gerrit-Change-Number: 31382
Gerrit-PatchSet: 1
Gerrit-Owner: James
jye836@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: James
jye836@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 16 Feb 2019 01:27:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment