21 Mar
2022
21 Mar
'22
7:41 p.m.
Attention is currently required from: Jakub Czapiga, Tim Wawrzynczak. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62709 )
Change subject: commonlib/timestamp_serialized: Add timestamp enum to name mapping ......................................................................
Patch Set 7: Code-Review+2
(1 comment)
File src/commonlib/include/commonlib/timestamp_serialized.h:
https://review.coreboot.org/c/coreboot/+/62709/comment/3cdecf2b_e752e45e PS7, Line 169: ts_name_def nit: not really a function-like macro, so the name should be in ALL_CAPS
--
To view, visit https://review.coreboot.org/c/coreboot/+/62709
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd49f20d6b00a5bbd21804cea3a50b8cef074cd1
Gerrit-Change-Number: 62709
Gerrit-PatchSet: 7
Gerrit-Owner: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 21 Mar 2022 18:41:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment