Attention is currently required from: Martin L Roth.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77580?usp=email )
Change subject: util/scripts: Improve update_submodules script ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/77580/comment/f26c027a_ec149cce : PS2, Line 21: - Add -m | --min_days argument to specify the min time (30 day default) This seems kind of odd to me so what's the typical use case? If the script's run automatically, I see the benefit. Would it make more sense for a user to not have to defeat the default yet let the system use the -m option for 30 days?
https://review.coreboot.org/c/coreboot/+/77580/comment/c2f401a5_a94df1fa : PS2, Line 33: plurl This reads like a typo in the commit message, although I see its context in the script. Change or don't change...
File util/scripts/update_submodules:
https://review.coreboot.org/c/coreboot/+/77580/comment/a7700424_00034822 : PS2, Line 234: echo "Error: Updated commit is earlier than the current commit." not sure whether this deserves a comment, i.e. if a reader might confuse the date they see in the log as the value gathered with %ct.