build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48383 )
Change subject: [WIP] mb/fujitsu/d3410-b1: Add new mainboard ......................................................................
Patch Set 2:
(53 comments)
File src/mainboard/fujitsu/d3410-b1/gpio.c:
https://review.coreboot.org/c/coreboot/+/48383/comment/c7d1ecfe_bc632017 PS2, Line 13: _PAD_CFG_STRUCT(GPP_A0, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/e841d1a8_7d864028 PS2, Line 14: _PAD_CFG_STRUCT(GPP_A1, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/5f87e854_3545f515 PS2, Line 15: _PAD_CFG_STRUCT(GPP_A2, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/105d838e_a4fcca9d PS2, Line 16: _PAD_CFG_STRUCT(GPP_A3, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/5063e3cd_f048fcef PS2, Line 17: _PAD_CFG_STRUCT(GPP_A4, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/3ac325fc_29972758 PS2, Line 18: _PAD_CFG_STRUCT(GPP_A5, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/ddc0437a_4f791c8c PS2, Line 19: _PAD_CFG_STRUCT(GPP_A6, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/2aaa2671_b0ccfa59 PS2, Line 20: _PAD_CFG_STRUCT(GPP_A7, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/7902f700_3ec74887 PS2, Line 21: _PAD_CFG_STRUCT(GPP_A8, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/8e1a31cb_8a2ed6cd PS2, Line 22: _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/dc022c95_63d16eb1 PS2, Line 23: _PAD_CFG_STRUCT(GPP_A10, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/1dcd5eb2_29933494 PS2, Line 24: _PAD_CFG_STRUCT(GPP_A11, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/77024b46_88e41746 PS2, Line 25: _PAD_CFG_STRUCT(GPP_A13, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/b418491d_0c3851e1 PS2, Line 26: _PAD_CFG_STRUCT(GPP_A15, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/5efec02a_672b300c PS2, Line 29: _PAD_CFG_STRUCT(GPP_A23, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/96998e46_f01e2c39 PS2, Line 33: _PAD_CFG_STRUCT(GPP_B12, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/d3894a5b_c144ea5e PS2, Line 34: _PAD_CFG_STRUCT(GPP_B13, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/3a95dbec_732f4d7e PS2, Line 35: _PAD_CFG_STRUCT(GPP_B14, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/f45b505e_805bc219 PS2, Line 37: _PAD_CFG_STRUCT(GPP_B18, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/7051b4df_c21d43b4 PS2, Line 38: _PAD_CFG_STRUCT(GPP_B22, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/b80d366d_8089cb2c PS2, Line 39: _PAD_CFG_STRUCT(GPP_B23, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/2bd15b3c_5e38e7e9 PS2, Line 44: _PAD_CFG_STRUCT(GPP_C0, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/fcb1f958_d157b2d5 PS2, Line 45: _PAD_CFG_STRUCT(GPP_C1, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/2995db48_862832b8 PS2, Line 46: _PAD_CFG_STRUCT(GPP_C2, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/fb060a61_8ecd911b PS2, Line 47: _PAD_CFG_STRUCT(GPP_C3, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/f458a6d7_00d088f4 PS2, Line 48: _PAD_CFG_STRUCT(GPP_C4, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/fcb21a82_594f88d6 PS2, Line 49: _PAD_CFG_STRUCT(GPP_C5, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/689f9543_51a1bc9c PS2, Line 50: _PAD_CFG_STRUCT(GPP_C8, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/de7347c7_d6f3a3d0 PS2, Line 51: _PAD_CFG_STRUCT(GPP_C9, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/8dd8155a_f2821579 PS2, Line 52: _PAD_CFG_STRUCT(GPP_C22, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/6bdff048_e9949377 PS2, Line 57: _PAD_CFG_STRUCT(GPP_D14, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/6034f0c6_046bf159 PS2, Line 58: _PAD_CFG_STRUCT(GPP_D15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/ee351b84_3788ef66 PS2, Line 59: _PAD_CFG_STRUCT(GPP_D18, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/01ba2fb7_019f8eb6 PS2, Line 62: _PAD_CFG_STRUCT(GPP_E8, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/3487374c_c268dc9e PS2, Line 63: _PAD_CFG_STRUCT(GPP_E9, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/3d594dd4_056b47a6 PS2, Line 64: _PAD_CFG_STRUCT(GPP_E10, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/c196e1c2_a41e3850 PS2, Line 65: _PAD_CFG_STRUCT(GPP_E11, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/453620a2_cbfea579 PS2, Line 66: _PAD_CFG_STRUCT(GPP_E12, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/aa581925_f95bf3e1 PS2, Line 69: _PAD_CFG_STRUCT(GPP_F15, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/fee5a6ff_ce997766 PS2, Line 70: _PAD_CFG_STRUCT(GPP_F16, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/915bfdaf_93c512d7 PS2, Line 79: _PAD_CFG_STRUCT(GPP_H0, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/f3488956_327365c8 PS2, Line 82: _PAD_CFG_STRUCT(GPP_H12, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/b07b71a1_72f872f3 PS2, Line 105: _PAD_CFG_STRUCT(GPP_I0, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/dfca4805_064dc7f8 PS2, Line 106: _PAD_CFG_STRUCT(GPP_I1, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/323ad390_5fb3c64c PS2, Line 107: _PAD_CFG_STRUCT(GPP_I2, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/1b66eadc_ef892a91 PS2, Line 108: _PAD_CFG_STRUCT(GPP_I3, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/e5d47fc5_633ef071 PS2, Line 109: _PAD_CFG_STRUCT(GPP_I5, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/4e34876d_16f5ad6f PS2, Line 110: _PAD_CFG_STRUCT(GPP_I6, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/f2499b13_807d9a06 PS2, Line 111: _PAD_CFG_STRUCT(GPP_I7, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/1c90bb6b_bcda4f8f PS2, Line 112: _PAD_CFG_STRUCT(GPP_I8, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/e9c6003c_c400b08d PS2, Line 113: _PAD_CFG_STRUCT(GPP_I9, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/f5a4c758_9e26fe8e PS2, Line 114: _PAD_CFG_STRUCT(GPP_I10, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
File src/mainboard/fujitsu/d3410-b1/romstage.c:
https://review.coreboot.org/c/coreboot/+/48383/comment/f6dca70e_f0352e70 PS2, Line 18: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)