Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44774 )
Change subject: mb: remove duplicated Make code for spd.bin generation
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44774/7/src/mainboard/google/dedede...
File src/mainboard/google/dedede/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44774/7/src/mainboard/google/dedede...
PS7, Line 3: ifneq ($(SPD_SOURCES),)
The check looks like a no-op now. Also makes me wonder, if the […]
1. Yes, that can be dropped indeed.
2. Ouch... good catch. An empty file gets added to cbfs. However, CONFIG_GENERIC_SPD_BIN should be disabled for dedede, anyways, as long as there is no spd specified.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44774
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd3ac0fd6c901228554115c6350d88bb49874587
Gerrit-Change-Number: 44774
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Sep 2020 21:58:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment