build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41943 )
Change subject: sb/intel/lynxpoint: Clean up code ......................................................................
Patch Set 10:
(5 comments)
https://review.coreboot.org/c/coreboot/+/41943/10/src/southbridge/intel/lynx... File src/southbridge/intel/lynxpoint/me_status.c:
https://review.coreboot.org/c/coreboot/+/41943/10/src/southbridge/intel/lynx... PS10, Line 83: [ME_HFS2_STATE_BUP_VSCC_ERR] = "Error reading/matching the VSCC table in the descriptor", line over 96 characters
https://review.coreboot.org/c/coreboot/+/41943/10/src/southbridge/intel/lynx... PS10, Line 86: [ME_HFS2_STATE_BUP_MANUF_OVRD_STRAP] = "Possibly handle BUP manufacturing override strap", line over 96 characters
https://review.coreboot.org/c/coreboot/+/41943/10/src/southbridge/intel/lynx... PS10, Line 121: [ME_HFS2_STATE_POLICY_FPB_ERR] = "Flash Partition Boundary is outside address space", line over 96 characters
https://review.coreboot.org/c/coreboot/+/41943/10/src/southbridge/intel/lynx... PS10, Line 122: [ME_HFS2_STATE_POLICY_DESCRIPTOR_ERR] = "ME cannot access the chipset descriptor region", line over 96 characters
https://review.coreboot.org/c/coreboot/+/41943/10/src/southbridge/intel/lynx... PS10, Line 123: [ME_HFS2_STATE_POLICY_VSCC_NO_MATCH] = "Required VSCC values for flash parts do not match", line over 96 characters