Piotr Kleinschmidt has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35482 )
Change subject: src/superio/nuvoton/nct5104d: soft reset GPIO ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35482/1/src/superio/nuvoton/nct5104... File src/superio/nuvoton/nct5104d/superio.c:
https://review.coreboot.org/c/coreboot/+/35482/1/src/superio/nuvoton/nct5104... PS1, Line 113: pnp_write_config(dev, LDN_SELECT_CR07, NCT5104D_GPIO);
I'd suggest using pnp_set_logical_device here
pnp_set_logical_device will work with LDN 7, but not with LDN F. It's because there isn't LDN F in devictree. Therefore, in nct5104d_init function we don't have access to such dev structure. Is there any other possibility to get to LDN F? Or should I stay with pnp_write_config?