Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h
File src/include/edid.h:
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h@109
PS10, Line 109: int row_byte_alignment);
Shouldn't we get rid of this too? I think this was only used to set bytes_per_line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39006
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c145ebcf33ae0e4ff8489d4d0bc1e46869912f3
Gerrit-Change-Number: 39006
Gerrit-PatchSet: 10
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Mar 2020 23:18:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment