Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39425 )
Change subject: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39425/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39425/9//COMMIT_MSG@7
PS9, Line 7: [WIP]
I would say it's pretty much done by now? I don't know if there's anything else missing before this […]
Done
https://review.coreboot.org/c/coreboot/+/39425/7/src/soc/intel/xeon_sp/gpio....
File src/soc/intel/xeon_sp/gpio.c:
https://review.coreboot.org/c/coreboot/+/39425/7/src/soc/intel/xeon_sp/gpio....
PS7, Line 65: .port = PID_GPIOCOM0,
My OCD says: Ah, gorgeous! Thank you! 😄
No problem, and thank you for the review :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idde32fdd53f1966e3ba6b7f5598ae8f51488d5a5
Gerrit-Change-Number: 39425
Gerrit-PatchSet: 10
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Mar 2020 20:11:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment