Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40524 )
Change subject: mb/ocp/tiogapass: Populate SMBIOS data and set the read PPIN to BMC ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40524/6/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/Kconfig:
https://review.coreboot.org/c/coreboot/+/40524/6/src/mainboard/ocp/tiogapass... PS6, Line 26: select OCP_DMI Let's put this in alphabetical order.
https://review.coreboot.org/c/coreboot/+/40524/6/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40524/6/src/mainboard/ocp/tiogapass... PS6, Line 18: ramstage-y += ipmi.c line 17, 18 can be in same line.
https://review.coreboot.org/c/coreboot/+/40524/6/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/ramstage.c:
https://review.coreboot.org/c/coreboot/+/40524/6/src/mainboard/ocp/tiogapass... PS6, Line 20: #include <drivers/ipmi/ipmi_ops.h> alphabetical order please.