Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31202 )
Change subject: arch/x86/timestamp.c: Don't depend on CONFIG_TSC_CONSTANT_RATE
......................................................................
Patch Set 2:
I see you already visited https://review.coreboot.org/c/coreboot/+/30762
I wuold rather fail build-time here. In case TSC_MONOTONIC_TIMER=y you get div-by-zero in delay_tsc.c with the weak implementation, but seems like it is behind three different Kconfig options if that happens.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31202
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c34eb811e27d2a91ccf1ca6f48a638da5f6cfd9
Gerrit-Change-Number: 31202
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Feb 2019 20:11:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment