Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yidi Lin, cong yang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74135 )
Change subject: mb/google/corsola: Report SKU and panel ID for unprovisioned devices ......................................................................
Patch Set 8:
(5 comments)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/74135/comment/06c07fab_b9e69016 PS6, Line 126: if (cached_sku_code == CROS_SKU_UNKNOWN) {
I think the CROS_SKU_UNPROVISIONED sku id is expected for kingler/krabby board, we don't want to cha […]
Ack
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/74135/comment/5d18282a_9f0a616c PS8, Line 73: Remove blank line.
https://review.coreboot.org/c/coreboot/+/74135/comment/a95ad780_42c3caa5 PS8, Line 116: STARMIE Can you upload another patch to rename this to `STARYU`?
https://review.coreboot.org/c/coreboot/+/74135/comment/ca934312_9c062271 PS8, Line 118: cached_sku_code Align with `cached_sku_code` in the previous line.
https://review.coreboot.org/c/coreboot/+/74135/comment/2661d9e2_3f4ce144 PS8, Line 128: get_adc_index Align