[coreboot-gerrit] [XS] Change in coreboot[main]: soc/mediatek/common/dp: Use DP_WRITE2BYTE if possible

[Yidi Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85918?usp=email )

Change subject: soc/mediatek/common/dp: Use DP_WRITE2BYTE if possible
......................................................................

soc/mediatek/common/dp: Use DP_WRITE2BYTE if possible

This patch prevents wrong mask passing to mtk_dp_mask.

TEST=emerge-rauru coreboot, check FW screen

Change-Id: If8c801173089761db55992279045d053c60dcd86
Signed-off-by: Yidi Lin 
---
M src/soc/mediatek/common/dp/dptx_hal.c
M src/soc/mediatek/common/dp/dptx_hal_common.c
2 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/85918/1

diff --git a/src/soc/mediatek/common/dp/dptx_hal.c b/src/soc/mediatek/common/dp/dptx_hal.c
index 97578d2..f3a6a41 100644
--- a/src/soc/mediatek/common/dp/dptx_hal.c
+++ b/src/soc/mediatek/common/dp/dptx_hal.c
@@ -120,7 +120,7 @@
    mtk_dp_write_byte(mtk_dp, REG_303C_DP_ENCODER0_P0 + 1,
    		  BIT(7), BIT(7));
    DP_WRITE2BYTE(mtk_dp, REG_3040_DP_ENCODER0_P0, 0x2020);
-	mtk_dp_mask(mtk_dp, REG_3364_DP_ENCODER1_P0, 0x2020, 0xfff);
+	DP_WRITE2BYTE(mtk_dp, REG_3364_DP_ENCODER1_P0, 0x2020);
    mtk_dp_write_byte(mtk_dp, REG_3300_DP_ENCODER1_P0 + 1,
    		  0x2, BIT(1) | BIT(0));
    mtk_dp_write_byte(mtk_dp, REG_3364_DP_ENCODER1_P0 + 1,
diff --git a/src/soc/mediatek/common/dp/dptx_hal_common.c b/src/soc/mediatek/common/dp/dptx_hal_common.c
index 4d4b9b8..a5b342f 100644
--- a/src/soc/mediatek/common/dp/dptx_hal_common.c
+++ b/src/soc/mediatek/common/dp/dptx_hal_common.c
@@ -263,12 +263,12 @@

void dptx_hal_setsdp_downcnt_init_inhblanking(struct mtk_dp *mtk_dp, u16 value)
 {
-	mtk_dp_mask(mtk_dp, REG_3364_DP_ENCODER1_P0, value, 0xfff);
+	DP_WRITE2BYTE(mtk_dp, REG_3364_DP_ENCODER1_P0, value);
 }

void dptx_hal_setsdp_downcnt_init(struct mtk_dp *mtk_dp, u16 value)
 {
-	mtk_dp_mask(mtk_dp, REG_3040_DP_ENCODER0_P0, value, 0xfff);
+	DP_WRITE2BYTE(mtk_dp, REG_3040_DP_ENCODER0_P0, value);
 }

bool dptx_hal_auxread_bytes(struct mtk_dp *mtk_dp, u8 cmd, u32 dpcd_addr, size_t length,