Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31477 )
Change subject: riscv: workaround selfboot putting the coreboot table into prog_entry_arg ......................................................................
Patch Set 10:
Patch Set 10:
Patch Set 10: Code-Review-2
We have two conflicting standards here: selfboot and RiscV BBL. Other arch like arm still use the coreboot table on SELF, even though the kernel requires a devicetree as argument. Changing the argument of SELF would break libpayload (which could be fixed). If we'd decide to always use the RiscV bbl calling conventions it needs to be documented in Documentation/. -2 until at least documentation is added to avoid future confusion about conflicting standards.
The WIP libpayload implementation also uses the RISC-V calling convention with hartid+fdt as arguments.
Oh great, we have documentation that doesn't match what the code does.
Again, please update the documentation, explaining the conflict and mention that on SELF payloads we ignore the SELF standard and also use the RISC-V calling convention.