Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37326 )
Change subject: AGESA,binaryPI: Split romstage_main() to BSP and AP parts ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37326/1/src/drivers/amd/agesa/romst... File src/drivers/amd/agesa/romstage.c:
https://review.coreboot.org/c/coreboot/+/37326/1/src/drivers/amd/agesa/romst... PS1, Line 56: if (initial_apic_id == 0) {
Is this check still needed?
Good question. I believe this originates from multi-socket platforms and the intention was for only one core to execute this initialisation path. For each socket, one core would reports as boot_cpu() from what I remember.
https://review.coreboot.org/c/coreboot/+/37326/1/src/drivers/amd/agesa/romst... PS1, Line 106: ap_romstage_main
no bist checking?
Ack