Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34625 )
Change subject: src/arch/x86/acpi: Constify struct device instances
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34625/1/src/arch/x86/acpi.c
File src/arch/x86/acpi.c:
https://review.coreboot.org/c/coreboot/+/34625/1/src/arch/x86/acpi.c@948
PS1, Line 948: unsigned long acpi_write_dbg2_pci_uart(acpi_rsdp_t *rsdp, unsigned long current,
We're past the 4.10 release, so there will be a clang-format run soon. […]
I'm fine with that. I can't wait to not have to worry about spacing.
https://review.coreboot.org/c/coreboot/+/34625/1/src/arch/x86/include/arch/a...
File src/arch/x86/include/arch/acpi.h:
https://review.coreboot.org/c/coreboot/+/34625/1/src/arch/x86/include/arch/a...
PS1, Line 904: const struct device *dev, uint8_t access_size);
That would push it over 80 chars, will have to then split in 3 lines, did not look good. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34625
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2ce045f17efa288eb41503795723d0ad5ec78bd
Gerrit-Change-Number: 34625
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 02 Aug 2019 15:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment