build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38240 )
Change subject: asus/am1i-a: fix the blue "USB 3.0" ports for OHCI/EHCI "USB 2.0" mode ......................................................................
Patch Set 1:
(28 comments)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/i... File src/mainboard/asus/am1i-a/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/i... PS1, Line 42: {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/i... PS1, Line 42: {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/i... PS1, Line 42: {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/i... PS1, Line 42: {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... File src/mainboard/asus/am1i-a/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 80: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 80: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 80: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 81: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 81: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 81: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... File src/mainboard/asus/am1i-a/mptable.c:
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 94: PCI_INT(0x0, 0x16, 0x0, intr_data_ptr[PIRQ_OHCI3]); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 94: PCI_INT(0x0, 0x16, 0x0, intr_data_ptr[PIRQ_OHCI3]); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 95: PCI_INT(0x0, 0x16, 0x1, intr_data_ptr[PIRQ_EHCI3]); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 95: PCI_INT(0x0, 0x16, 0x1, intr_data_ptr[PIRQ_EHCI3]); please, no spaces at the start of a line