Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32880 )
Change subject: soc/fsp_broadwell_de: fix flashconsole support for platform
......................................................................
Patch Set 1:
Patch Set 1:
in that case, should I revert CB:30506 wholly, or just spi.c?
and should we have fsp_baytrail use the sb/common implementation too, or are there differences warranting keeping it separate?
Though one. On one hand the project should move towards NO_CAR_GLOBAL_MIGRATION and get rid car_set/get_*, on the other hand you want more common code...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32880
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72e5db1583199b5ca4b6ec54661282544d326f0f
Gerrit-Change-Number: 32880
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 20 May 2019 01:29:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment