Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33265 )
Change subject: Documentation: libgfxinit timing parameters ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Just two small comments...
Please make sure that the `Change-Id` is kept in the commit message. Last resort, copy it manually.
https://review.coreboot.org/#/c/33265/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33265/1//COMMIT_MSG@7 PS1, Line 7: libgfxinit timing parameters This should be an imperative statement, e.g. `Add Intel GMA timing parameters`
https://review.coreboot.org/#/c/33265/1/Documentation/gfx/intel-gma.md File Documentation/gfx/intel-gma.md:
https://review.coreboot.org/#/c/33265/1/Documentation/gfx/intel-gma.md@27 PS1, Line 27: Haswell AIUI, this numbering is `eDP` specific (not platform specific).