Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33775 )
Change subject: arch/x86: Adjust size of postcar stack
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33775/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33775/3//COMMIT_MSG@12
PS3, Line 12: was no longer sufficient.
I did not entirely understand the original argumentation and or references to commits with regression. What do we need to say here to make it comprehensible?
https://review.coreboot.org/#/c/33775/3/src/drivers/intel/fsp1_1/car.c
File src/drivers/intel/fsp1_1/car.c:
https://review.coreboot.org/#/c/33775/3/src/drivers/intel/fsp1_1/car.c@74
PS3, Line 74: aligned_ram = ALIGN_DOWN(romstage_ram_stack_bottom(), alignment);
This needs some fix, but I did not understand the purpose of this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33775
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba1fb5bfad6946f316feac2d8c998a782142a56a
Gerrit-Change-Number: 33775
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 28 Jun 2019 10:37:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment