Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32448 )
Change subject: soc/intel/apollolake/bootblock: Clear the GPI IS & IE registers ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32448/1/src/mainboard/google/octopus/mainboa... File src/mainboard/google/octopus/mainboard.c:
https://review.coreboot.org/#/c/32448/1/src/mainboard/google/octopus/mainboa... PS1, Line 74: gpi_clear_int_cfg
I will pick up option 1, since that seems to give more control regarding where this function is used […]
Done