Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, Arthur Heymans.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63167 )
Change subject: soc/intel/alderlake: Disable FSP debug output if !HAVE_FSP_DEBUG
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/63167/comment/d2ef8b38_6f3c7aca
PS2, Line 378: m_cfg->PcdSerialDebugLevel = 0;
Should this move to if (CONFIG(FSP_USES_CB_DEBUG_EVENT_HANDLER)) {} else {}? […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63167
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I779c56b8b0fdebf45ea85b3b456a2d8066e26489
Gerrit-Change-Number: 63167
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 29 Mar 2022 07:55:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment