[coreboot-gerrit] Change in coreboot[master]: soc/intel/{cnl, icl}: Allocate 64KB as FSP heap

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35237 )

Change subject: soc/intel/{cnl, icl}: Allocate 64KB as FSP heap
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35237/1/src/soc/intel/cannonlake/Kc... 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/c/coreboot/+/35237/1/src/soc/intel/cannonlake/Kc... 
PS1, Line 122: 	default 0x20000 if FSP_USES_CB_STACK
> Shouldn't this be reduced now?

If 64KB was used for the HOB heap, then shouldn't this be 0x10000 now?  Or should we change this to 96KB (160KB - 64KB) ?

https://review.coreboot.org/c/coreboot/+/35237/1/src/soc/intel/cannonlake/Kc... 
PS1, Line 131: 0x10000
64KB worth of HOBs?