Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38270 )
Change subject: Make: Add supermicro/smcbiosinfo to tools
......................................................................
Patch Set 1:
Why is moving this fixing the issue? I do not understand it.
It's not just shuffling things around. `smcbiosinfo` is added
to the `tools` target so that it gets built in advance by abuild,
before any parallel board builds. Moving the `ifeq` around is
required so that it can be built without depending on a `.config`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38f7ee2fdef2818ad685b3de53ad74f7da50600f
Gerrit-Change-Number: 38270
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jan 2020 16:23:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment