Attention is currently required from: Nicholas Chin.
Julius Werner has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85905?usp=email )
Change subject: drivers/option: Add CBFS file based option backend ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: BTW I think it would be another useful change if `cbfstool add-int` would automatically replace the old file if it already exists (right now it errors out and you have to call `cbfstool remove` manually), since it's specifically designed to manipulate these sorts of small option files.
File src/drivers/option/cbfs_file_option.c:
https://review.coreboot.org/c/coreboot/+/85905/comment/62aae95a_2d06dd96?usp... : PS2, Line 11: cbfs_map Note that when using boards with CONFIG_VBOOT, this will read from the current slot (RO/RW_A/RW_B). This creates all kinds of complications that are probably not helpful for this (e.g. need to pass `-r FW_MAIN_A` or something like that to cbfstool every time, different stages could be using different option values, RW CBFSes need to be resigned each time after running cbfstool). Since people with manual flash access who'd be using this can usually reflash the RO section anyway, I think it would probably make more sense here to use `cbfs_ro_map()` and just always read this file from RO.
https://review.coreboot.org/c/coreboot/+/85905/comment/58731a3b_274e588f?usp... : PS2, Line 11: name Since the option names are all over the place, should we group them under a prefix in CBFS (e.g. `option/<optionname>`) to give it a bit more structure?