Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31639 )
Change subject: sb/intel/common/firmware: Add an option to use IFDTOOL
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31639/1/src/southbridge/intel/common/firmwar...
File src/southbridge/intel/common/firmware/Makefile.inc:
https://review.coreboot.org/#/c/31639/1/src/southbridge/intel/common/firmwar...
PS1, Line 86: cp $(obj)/coreboot.pre $(obj)/coreboot.pre.new
: mv $(obj)/coreboot.pre.new $(obj)/coreboot.pre
Isn't this effectively copying $(obj)/coreboot.pre to $(obj)/coreboot.pre?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46ec6339008edcc78fe76682eed5714f85354937
Gerrit-Change-Number: 31639
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Feb 2019 15:50:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment