Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35014 )
Change subject: Move and rename ARCH_STAGE_HAS_xxx_SECTION rules ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35014/4/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/35014/4/src/include/rules.h@270 PS4, Line 270: /* No .data or .bss sections. Cache as RAM is handled separately. */
Append the comment to refer to the file which handles that? arch/x86/car. […]
Looking at x86/memlayout.ld, it includes <memlayout.h> which includes <xx/program.ld> via BOOTBLOCK(), VERSTAGE() and ROMSTAGE() macros?
https://review.coreboot.org/c/coreboot/+/35014/4/src/lib/program.ld File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/35014/4/src/lib/program.ld@129 PS4, Line 129: .bss . : { Not good.. .bss ends up inside execute-in-place bootblock with CB:35003.
Idx Name Size VMA LMA File off Algn 0 .text 00001fd8 ffffc000 ffffc000 00001000 2**12 CONTENTS, ALLOC, LOAD, RELOC, READONLY, CODE 1 .bss 00000010 ffffdfd8 ffffdfd8 00002fd8 2**2 ALLOC 2 .car.data 00002e50 fefc0000 fefc0000 00000000 2**0 ALLOC