build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43133 )
Change subject: baytrail RFC: native replacement for refcode.elf ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/incl... File src/soc/intel/baytrail/include/soc/modphy_table.h:
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/incl... PS5, Line 15: #define MODPHY_ENTRY_END (struct modphy_entry) { 0, 0, 0, 0, 0, 0 } Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/refc... File src/soc/intel/baytrail/refcode_native.c:
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/refc... PS5, Line 47: #define IOSF_READ(op_read, port) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/43133/5/src/soc/intel/baytrail/refc... PS5, Line 49: #define IOSF_WRITE(op_write, port) \ Macros with complex values should be enclosed in parentheses