Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38306 )
Change subject: mb/asrock: Add Asrock FM2A88M-HD+ FM2+ ......................................................................
Patch Set 4:
(2 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/38306/3/src/mainboard/asrock/fm2a88... File src/mainboard/asrock/fm2a88m-hd-plus/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/38306/3/src/mainboard/asrock/fm2a88... PS3, Line 171: if (CONFIG(BOARD_ASROCK_FM2A88M_HD_PLUS)) Need to make sure that the latest revision of your CB:38306 is as similar to CB:30987 as possible, to avoid the double work like the removal of this line I just did. Maybe would be easier to get A88XM-E merged first, then go ahead with this one.
https://review.coreboot.org/c/coreboot/+/38306/4/src/mainboard/asrock/fm2a88... File src/mainboard/asrock/fm2a88m-hd-plus/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/38306/4/src/mainboard/asrock/fm2a88... PS4, Line 169: /* Set to 0x40 instead of 0xE0 to avoid the PCI resource allocation problems. */ : InitPost->MemConfig.BottomIo = 0x40; See CB:30987 comment here for more info - https://review.coreboot.org/c/coreboot/+/30987/45/src/mainboard/asus/a88xm-e...