Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46036 )
Change subject: drivers/intel/wifi: Change to PCI driver only
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46036/3/src/drivers/intel/wifi/wifi...
File src/drivers/intel/wifi/wifi.c:
https://review.coreboot.org/c/coreboot/+/46036/3/src/drivers/intel/wifi/wifi...
PS3, Line 58: wifi_generic_ops
Ideally we could move this pci_driver into drivers/generic/wifi, but I am not sure if we want to add all the Intel PCI IDs in the generic/wifi driver.
IMHO that is cleaner than leaving these externs, and it's still semantically correct, the Intel wifi chips still use the machinery from the generic/wifi driver.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46036
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I780a7d1a87f387d5e01e6b35aac7cca31a2033ac
Gerrit-Change-Number: 46036
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 09 Oct 2020 18:04:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment