Attention is currently required from: Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48383 )
Change subject: mb/fujitsu/d3410-b1: Add new mainboard
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/fujitsu/d3410-b1/Kconfig:
https://review.coreboot.org/c/coreboot/+/48383/comment/2fc8ec58_9c0e077a
PS5, Line 34: config USE_LEGACY_8254_TIMER
SeaBIOS hangs without it, but it should be enabled by default in that case.
Gone
File src/mainboard/fujitsu/d3410-b1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48383/comment/af89a11c_711fb8c2
PS5, Line 77: register "SataTestMode" = "1
Fine, I'll make it a Kconfig option instead.
CB:52099
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fd843cd783b0324866933b95dd46eaccb634ba8
Gerrit-Change-Number: 48383
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sun, 04 Apr 2021 14:45:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment