Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32905
to look at the new patch set (#5).
Change subject: RFC: smbios: allow setting BIOS version string from VPD variable ......................................................................
RFC: smbios: allow setting BIOS version string from VPD variable
As in the title. Such approach allows for convenient setting of the firmware version and keep it in partition that is easily readable from both - coreboot binary and already running operating system.
It can be used in cases when we still need to rely on SMBIOS for legacy reasons (old closed source software that is not aware of presence of VPD).
vpd_find is used directly as it returns pointer to vpd value which, by spec, is terminated by 0x00 (VPD_TYPE_TERMINATOR) anyway. This way we avoid copying string around and coming up with temporary buffer.
Change-Id: If0e9d90ed0941c4e76e3e48cdcccf830ef789458 Signed-off-by: Lukasz Siudut lsiudut@gmail.com --- M src/arch/x86/smbios.c 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/32905/5