Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55788 )
Change subject: soc/intel/apollolake/xdci.c: Use `dev` parameter ......................................................................
soc/intel/apollolake/xdci.c: Use `dev` parameter
The `dev` parameter already points to the xDCI device.
Change-Id: I122cc642c86b30804dd1176f77f4e2e1ebea4aa0 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/55788 Reviewed-by: Subrata Banik subrata.banik@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/apollolake/xdci.c 1 file changed, 2 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/xdci.c b/src/soc/intel/apollolake/xdci.c index 56d4c87..8c86e44 100644 --- a/src/soc/intel/apollolake/xdci.c +++ b/src/soc/intel/apollolake/xdci.c @@ -34,19 +34,18 @@ const struct resource *res; uint32_t reg; struct stopwatch sw; - struct device *xdci_dev = PCH_DEV_XDCI;
/* * Only default to host mode if the xdci device is present and * enabled. If it's disabled assume the switch was already done * in FSP. */ - if (!dev->enabled || !xdci_dev->enabled || !xdci_can_enable()) + if (!dev->enabled || !xdci_can_enable()) return;
printk(BIOS_INFO, "Putting port 0 into host mode.\n");
- res = find_resource(xdci_dev, PCI_BASE_ADDRESS_0); + res = find_resource(dev, PCI_BASE_ADDRESS_0);
cfg0 = (void *)(uintptr_t)(res->base + DUAL_ROLE_CFG0); cfg1 = (void *)(uintptr_t)(res->base + DUAL_ROLE_CFG1);