Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35726 )
Change subject: drivers/aspeed/common: Add support for high resolution framebuffer ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35726/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35726/1//COMMIT_MSG@10 PS1, Line 10: Copy the linux kernel code and add a bunch of wrapper structs to make it : compile. : Convert the EDID to a drm_display_mode, which is understood by the : driver.
Please format this as a list, if you list the changes.
Done
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_i2c.c:
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... PS1, Line 126: software_i2c[bus] = &ast_ops;
You should probably have a check or assert for the bus number here, since your code is clearly only […]
Reworked i2c handling
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... PS1, Line 133: ast = ast_priv;
Both functions are only called once. I'll remove one of them.
Reworked i2c handling
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_mode.c:
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... PS1, Line 1:
Remove blank line?
Done