Attention is currently required from: Furquan Shaikh, Angel Pons, Subrata Banik, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50176 )
Change subject: soc/intel/common: Add `struct gpio_pad_table` and helpers
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I just had another idea: what about this?
#define GPIO_PAD_ARRAY(name, table) const struct gpio_pad_table name = { \
.padcfg = table, \
.length = ARRAY_SIZE(table), \
};
`const struct gpio_pad_table variant_gpio_table = GPIO_PAD_ARRAY(gpio_table);` would become:
`GPIO_PAD_ARRAY(variant_gpio_table, gpio_table)` just like the bootstate macros.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50176
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If029bbafe186d36a971d91b3b6b9220616e04141
Gerrit-Change-Number: 50176
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 01 Feb 2021 21:03:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment