[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add northbridge pci driver

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34424 )

Change subject: soc/amd/picasso: Add northbridge pci driver
......................................................................

Patch Set 31:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34424/31/src/soc/amd/picasso/northb... 
File src/soc/amd/picasso/northbridge.c:

https://review.coreboot.org/c/coreboot/+/34424/31/src/soc/amd/picasso/northb... 
PS31, Line 41: for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) {
> The PPR states the following: BIOS must include the DRAM system-physical addresses that are used for […]

Adding PCIe enhanced config space BAR 0xf8000000-0xfc000000.
read_resources: SYSTEM_MEMORY:
    addr: 0x0000000000000000 (0 MB)
    length: 3456106496 (3296 MB)
    end: 0x00000000ce000000 (3296 MB) <- This is 8M above cbmem.. why? Is this TOM1?
Skipping, below mem_usable: 0x00000000cd800000 <- cbmem_top

read_resources: RESERVED SYSTEM_MEMORY:
    addr: 0x00000000ce000000 (3296 MB) <-- Right after TOM1
    length: 33554432 (32 MB)
    end: 0x00000000d0000000 (3328 MB)

read_resources: SYSTEM_MEMORY:
    addr: 0x0000000100000000 (4096 MB)
    length: 5086904320 (4851 MB)
    end: 0x000000022f340000 (8947 MB) <-- I'm guessing this is TOM2

read_resources: RESERVED SYSTEM_MEMORY:
    addr: 0x000000022f340000 (8947 MB)
    length: 13369344 (12 MB)
    end: 0x0000000230000000 (8960 MB)

read_resources: RESERVED SYSTEM_MEMORY:
    addr: 0x00000000cd800000 (3288 MB)
    length: 8388608 (8 MB)
    end: 0x00000000ce000000 (3296 MB) <- Looks like this is why CBMEM is 8MB below TOM1

read_resources: RESERVED SYSTEM_MEMORY:
    addr: 0x00000000cd7fe000 (3287 MB)
    length: 8192 (0 MB)
    end: 0x00000000cd800000 (3288 MB) <- This is inside CBMEM, is FSP-M overriding something?

read_resources: RESERVED SYSTEM_MEMORY:
    addr: 0x00000000cc7fe000 (3271 MB)
    length: 16777216 (16 MB)
    end: 0x00000000cd7fe000 (3287 MB) <- This is also inside CBMEM

read_resources: RESERVED SYSTEM_MEMORY:
    addr: 0x0000000001090000 (16 MB)
    length: 720896 (0 MB)
    end: 0x0000000001140000 (17 MB)