Attention is currently required from: Christian Walter, Jincheng Li, Johnny Lin, Jonathan Zhang, Tim Chu.
Patrick Rudolph has posted comments on this change by Jincheng Li. ( https://review.coreboot.org/c/coreboot/+/85737?usp=email )
Change subject: soc/intel/xeon_sp: Remove assert when creating DMAR component
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85737/comment/82d90644_f1a00a33?usp... :
PS1, Line 10: Remove
The leading IOAT domains of specific IIO stack will have VTD, but the remaining ones will not.
You are writing that multiple domains *share* a VTD, how does that work when you iterate only over devices in the current domain?
That doesn't answer the question. Let me rephrase:
Can domains without VTD be safely ignored in DMAR handling?
If so the code should be updated since on gen1-gen5 there are only domains that have a VTD and no domain is ever ignored.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85737?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I64256baf10abb509d48267e58e6a9e264b916e72
Gerrit-Change-Number: 85737
Gerrit-PatchSet: 1
Gerrit-Owner: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 23 Dec 2024 08:36:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com