Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38204 ) Change subject: [WIP]mainboard/lenovo: do initial commit for t540p ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/38204/2/src/mainboard/lenovo/t540p/... File src/mainboard/lenovo/t540p/devicetree.cb: https://review.coreboot.org/c/coreboot/+/38204/2/src/mainboard/lenovo/t540p/... PS2, Line 2: register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }" : register "gfx.ndid" = "3" Do we need these gfx.[n]did in devicetrees? I've tried to grep through ./src directory and cannot find anything related. -- To view, visit https://review.coreboot.org/c/coreboot/+/38204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02ecde6999d1b5ca7741371273edd90297899fa0 Gerrit-Change-Number: 38204 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Elsen Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Elsen Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Idwer Vollering <vidwer@gmail.com> Gerrit-CC: Peter Lemenkov <lemenkov@gmail.com> Gerrit-Comment-Date: Mon, 06 Jan 2020 10:23:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment