5 Aug
2019
5 Aug
'19
4:39 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34515 )
Change subject: soc/mediatek/mt8173: Refactor display driver to share common parts ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34515/7/src/soc/mediatek/common/inc... File src/soc/mediatek/common/include/soc/ddp_common.h:
https://review.coreboot.org/c/coreboot/+/34515/7/src/soc/mediatek/common/inc... PS7, Line 111: 2 Why is it changed from 3 to 2?
If you're changing this, consider removing DISP_RDMA2_BASE from addressmap.h.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34515
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5709ab6e263caa21fdf7e799dc2ee884ffaf800
Gerrit-Change-Number: 34515
Gerrit-PatchSet: 7
Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Jitao Shi jitao.shi@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: yongqiang niu yongqiang.niu@mediatek.com
Gerrit-CC: SJ Huang sj.huang@mediatek.corp-partner.google.com
Gerrit-CC: Yongqiang Niu yongqiang.niu@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 05 Aug 2019 02:39:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment