Attention is currently required from: Martin Roth, Christian Walter, Angel Pons. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44772 )
Change subject: mb/prodrive/hermes/hda_verb: Update verb table for latest board revision ......................................................................
Patch Set 8:
(3 comments)
File src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/44772/comment/6ba45903_20c37fa2 PS7, Line 34: AZALIA_PIN_CFG(0, 0x18, 0x01a19c50), /* PORT B - rear mic in */
Place this one right after 0x17?
Done
File src/mainboard/prodrive/hermes/variants/r02/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/44772/comment/7b8c89a0_0b98d66b PS7, Line 18: return;
Should we move this check out of the revision-specific boards? We could then rename these functions […]
Done
File src/mainboard/prodrive/hermes/variants/r03/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/44772/comment/007fe03f_8a25c28f PS7, Line 12: AZALIA_PIN_CFG(0, 0x1b, 0x02214c40), /* PORT E - front hp out */
Already configured using board settings?
Done