Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41272 )
Change subject: soc/amd/common/block: Add support for configuring eSPI connection to slave ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41272/1/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/41272/1/src/soc/amd/common/block/lp... PS1, Line 396: /* Wait upto ESPI_CMD_TIMEOUT_US for hardware to clear DNCMD_STATUS bit. */
'upto' may be misspelled - perhaps 'up to'?
Done
https://review.coreboot.org/c/coreboot/+/41272/1/src/soc/amd/common/block/lp... PS1, Line 421: * Wait upto ESPI_CMD_TIMEOUT_US for interrupt status register to update after sending a
'upto' may be misspelled - perhaps 'up to'?
Done